Detector icon indicating copy to clipboard operation
Detector copied to clipboard

Binary websocket support and IE10

Open tyssen opened this issue 11 years ago • 9 comments

I've created an add-on for ExpressionEngine that uses Detector and it works fine everywhere except for IE10 where you get a blank page because it fails at the Modernizr test stage with an unspecified error for:

Modernizr.addTest("websocketsbinary",!!window.WebSocket&&!!(new WebSocket("ws://.")).binaryType)

Looking through the issues for Modernizr, it seems this came up a while ago with a fix merged in a few months ago.

I'm wondering if it would be possible to update the custom build that Detector uses to include this fix? I know I could create my own custom build, but I'm not sure what customisations were made to achieve the build used with Detector.

tyssen avatar Jun 27 '13 01:06 tyssen

Just wondering what the status of this is.

tyssen avatar Jul 15 '13 21:07 tyssen

I'll try to get this worked into Detector this week (most likely Wednesday).

dmolsen avatar Jul 16 '13 01:07 dmolsen

Great, thanks.

I'll try to get this worked into Detector this week (most likely Wednesday).

— Reply to this email directly or view it on GitHub (https://github.com/dmolsen/Detector/issues/21#issuecomment-21016026).

tyssen avatar Jul 16 '13 01:07 tyssen

the fix will be in on monday. sorry for the delay.

dmolsen avatar Jul 18 '13 18:07 dmolsen

Did you get a chance to fix this?

builtbymonkey avatar Jul 31 '13 14:07 builtbymonkey

Any news here? A fix would be great!

doitux avatar Oct 09 '13 11:10 doitux

Following up on this again.

tyssen avatar Dec 02 '13 04:12 tyssen

Any news on this issue? Detection is also broken on IE 11. Could some developer comment on this, please, whether it will be fixed or not? This has been broken for a long time now.

lotodore avatar Dec 23 '13 19:12 lotodore

I posted ans issue #24 and I think there is nobody on detector since a long time. What a pity! Because I like detector's concept, maybe it is possible I will decide to make a fork.

alainb2p avatar Jan 27 '14 02:01 alainb2p