lLyrics icon indicating copy to clipboard operation
lLyrics copied to clipboard

Add parser for reading from the song's tags or from a local .lrc/.lyric file

Open alpemwarrior opened this issue 5 years ago • 6 comments

The user can select "Local File" as a source, which will fetch lyrics from the song's metadata (mp3, ogg, opus and flac only) or from a .lrc or .lyric file with the same filename in the same path. Also edited the README to mention the use of the mutagen library.

alpemwarrior avatar Jul 29 '20 10:07 alpemwarrior

Thanks for the feedback! I'll rewrite it and update it. No idea about how the translation stuff works, but I'll look into it. Also, there is an ugly patch in lLyrics.py because the parser needs the song url to work. Is this fine or is there a more elegant way to do it?

alpemwarrior avatar Jul 29 '20 13:07 alpemwarrior

I have looked into the translation stuff and it should be easy to do. Can't update any of them tho. I decided not to use pathlib because the object syntax is just weird for what i'm trying to do, and os.path is not deprecated or anything. Other than that, everything else has been fixed.

alpemwarrior avatar Jul 29 '20 13:07 alpemwarrior

Thanks again for your time and feedback!

alpemwarrior avatar Jul 29 '20 20:07 alpemwarrior

Hi, @dmo60. I think this is ready to squash & merge. Do you think you can take a look?

ratijas avatar Aug 03 '20 18:08 ratijas

@dmo60 Sorry to bump you on this, but it is kind of stagnating. Is there anything blocking from merge & release?

Alternatively, you could add me as a maintainer. I am skillful with Python and many other stuff, and I got a load of free time lately.

ratijas avatar Aug 19 '20 16:08 ratijas

@dmo60 Hello, any news for merging this into master?

wolf-yuan-6115 avatar Dec 19 '23 14:12 wolf-yuan-6115