Desmond Brand
Desmond Brand
I can imagine scenarios where it makes sense to configure feedback strategy on a Field-specific basis. I suppose the user can always decide not to render an error themselves, but...
We should start using hooks internally. Hopefully no tests are dependent on class internals, but if so, they'll need to be changed too.
It's a dodgy to equate `"unchecked"` and especially `"pending"` with valid. Arguably it's client code's responsibility to know when external validations are pending, so the problem is worse for internal...
I think there's room for F1 to have more of an opinion on `FeedbackStrategy` that will nudge users towards better UX. Right now the default is `Always` which is really...
add `all=error` to `[lints]` in `.flowconfig`, then fix / line-disable all existing errors
Consider changing `onSubmit`'s arguments to `(FormulaOneResult, ExtraSubmitData)` , where: ```js type FormulaOneResult = | { valid: true, value: T } | { valid: false, internalValid: boolean, // or clientValid, if...
It looks like under some circumstance we don't understand, the `valid` argument to the `Form`'s render prop can report the wrong value. This caused type errors in Flexport's app because...
To make sure our typing is working, we could (a) brainstorm what kind of type errors we want to prevent then (b) ensure that all of these potential errors have...
`ArrayField`'s `customChange` doesn't run in response to mutators (`addField`, `filterFields` & friends). But it should run.
It'd be nice to have a measurement for (a) test coverage and (b) Flow coverage. Maybe these numbers can show up in a badge on the readme?