feat: add max_configs_to_run param

Open svenrisse opened this issue 1 year ago • 4 comments

Add a max_configs_to_run (somebody got a better name?) param that defaults to previously hardcoded 20 to allow plugin user to increase the number of allowed tsconfig files.

My monorepo has 26 tsconfig files and I was prohibited by the set max of 20 to run :TSC.

Or is there a specific to reason to not go over 20 files?

Thanks for the great work on this plugin.

Dec 12 '24 09:12 svenrisse

Will try to get to this this weekend - thanks for the PR!

Dec 13 '24 21:12 dmmulroy

@dmmulroy Hey is there anything I can help you with to get this reviewed? :)

Jan 28 '25 12:01 svenrisse

@svenrisse so sorry this got drowned out in my notifications

Jan 29 '25 16:01 dmmulroy

@dmmulroy hey, is there anything else I can do to help in this PR? I've applied your suggestion, am unsure why it still says Changes requested

Feb 26 '25 12:02 svenrisse

Do we even need to check for a max amount of configs_to_run? I also just ran into this issue. Maybe it's the way we set up our monorepo, but we have 34 tsconfigs.

May 16 '25 15:05 michaelforgit