David M. Lloyd

Results 306 comments of David M. Lloyd

What if, instead of multi-value, there's a separate instruction that only yields the "carry" of an add operation? Surely the backend JIT or compiler (if any) could easily coalesce the...

The code change for this is very simple; what complexity there is mainly revolves around testing. Specifically, ensuring that all backend-specific code is guarded by `Build.Target.is(Wasm|Llvm)`.

I'd be fine with disabling it by default.

18 is independently unavailable on homebrew and from `install-llvm-action` as of yet.

Finally, a legitimate failure. It looks like this: ```console $ ./integration-tests/target/native/qbicc-integration-tests snippet-ServiceLoading Exception in thread "main" java.lang.InternalError: Malformed Stack at java.base/java.lang.Throwable.fillInStackTrace(Throwable$_patch.java:46) at java.base/java.lang.Throwable.fillInStackTrace(Throwable.java:798) at java.base/java.lang.Throwable.(Throwable.java:271) at java.base/jdk.internal.reflect.Reflection.getCallerClass(Reflection$_native.java:50) at org.qbicc.tests.snippets.ServiceLoading.main(ServiceLoading.java:24) ```

I gave some examples up above. We're using more indy and condy in generated bytecode, but some of these constructs cannot work in GraalVM (particularly where class definition is involved)....

I'm not sure, I guess it depends on how tolerant it is. I haven't experimented much with it yet for native image myself but we are looking at increasing classloader...

> Just a note for consistency. There is [`JPMSExportBuildItem`](https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/builditem/nativeimage/JPMSExportBuildItem.java) which we use in native-mode. IMHO we should use similar names for both the "export" and the "open" builditems, so I...

> But before thinking of providing a more general solution I'd like to check if there's any need for this - as far as I can see that Fips Security...

I'm not sure I'd depend on a test to determine whether something is needed. But maybe it's worth trying to craft one to trigger the issue?