xgboost icon indicating copy to clipboard operation
xgboost copied to clipboard

[spark] Add validation for param 'early_stopping_rounds' and 'validation_indicator_col'

Open WeichenXu123 opened this issue 3 years ago • 4 comments

Signed-off-by: Weichen Xu [email protected]

Add validation for param 'early_stopping_rounds' and 'validation_indicator_col'

WeichenXu123 avatar Sep 20 '22 14:09 WeichenXu123

CC @trivialfis @wbo4958 Thanks!

WeichenXu123 avatar Sep 20 '22 14:09 WeichenXu123

@trivialfis @wbo4958 Ready for merging ! :)

WeichenXu123 avatar Sep 22 '22 04:09 WeichenXu123

@trivialfis @wbo4958 Ready for merging :)

WeichenXu123 avatar Sep 22 '22 04:09 WeichenXu123

Will look into the CI and merge it today.

trivialfis avatar Sep 22 '22 04:09 trivialfis

+1 ed.

wbo4958 avatar Sep 22 '22 08:09 wbo4958

Could you please fix the test?

trivialfis avatar Sep 22 '22 12:09 trivialfis

CC @trivialfis Tests fixed. Failed CIs are not related.

WeichenXu123 avatar Sep 26 '22 00:09 WeichenXu123