mshadow icon indicating copy to clipboard operation
mshadow copied to clipboard

[question] why just replace the inline keyword with predefined macro?

Open dzhwinter opened this issue 9 years ago • 1 comments

This is just a question about the source code. To improve the performance, it will be benefit to use inline function as many as possible. The MSHADOW_XINLINE is a force inline macro which defined in base.h. But sometimes inline key word appear here and there. for example, https://github.com/dmlc/mshadow/blob/master/mshadow/expression.h#L137 why just replace the inline keyword with predefined macro? Is it matter the performance? Or just use inline keywords where we can make sure that function will be execute in CPU .

dzhwinter avatar Nov 30 '15 02:11 dzhwinter

This code base has been donated to the Apache MXNet project per #373, and repo is deprecated. Future development and issue tracking should continue in Apache MXNet.

szha avatar Aug 04 '19 00:08 szha