keras icon indicating copy to clipboard operation
keras copied to clipboard

Merge this branch with Keras 2.0

Open rravu3 opened this issue 7 years ago • 15 comments

Hi,

Wanted to ask what are the plans to pull in Keras 2.0 as there have been interface level changes from 1.2.2.

Rahul

rravu3 avatar Jun 14 '17 21:06 rravu3

Yes. We will first finalize keras/mxnet for 1.2.2 and then switch to 2.0.

kevinthesun avatar Jun 27 '17 19:06 kevinthesun

Waiting for MXNet + Keras 2. I have networks developed based on Keras 2 and I am desperate for MXNet auto multi-GPU support....

yliu7366 avatar Aug 21 '17 14:08 yliu7366

@kevinthesun timeline? Why not try to merge this into Keras?

TimZaman avatar Sep 18 '17 22:09 TimZaman

:'( same as @yliu7366 I hope at least somebody has begun to work on this

edmondja avatar Oct 10 '17 22:10 edmondja

It would be great to have an update: are things still planned for a Keras2.0 upgrade?

davideboschetto avatar Oct 26 '17 16:10 davideboschetto

@sandeep-krishnamurthy

kevinthesun avatar Oct 26 '17 18:10 kevinthesun

Hi Yes. This is planned and work is in progress. I have implemented all basic tensor operators.. https://github.com/simpledl/keras/tree/mxnet_backend_keras2 Note above repo is just a placeholder I started working on. All work we do on Keras 2 will go to a PR on Keras 2.

sandeep-krishnamurthy avatar Oct 26 '17 20:10 sandeep-krishnamurthy

This is great @sandeep-krishnamurthy ! Keep up the good work, having the backend in keras2 would be amazing, thanks! Do you by any chance have a ballpark estimation for when the PR will come?

davideboschetto avatar Oct 27 '17 09:10 davideboschetto

Hello, Keras2+MXNet is almost complete. https://github.com/deep-learning-tools/keras/tree/keras2_mxnet_backend . Please try and provide your feedback.

I have created a PR - https://github.com/keras-team/keras/pull/9291 However, there are few design incompatibility with MXNet and Keras in the way Model compile and Optimizers are handled. Hence, few changes are requested by Keras community. These changes require significant modifications in MXNet Module and KVStore components. Hence, we talked to keras community to release the fork for the benefit of Keras users as the interface remains the same.

sandeep-krishnamurthy avatar Mar 20 '18 16:03 sandeep-krishnamurthy

@sandeep-krishnamurthy How to install the Keras2-compatible version ?

edmondja avatar Mar 24 '18 18:03 edmondja

@edmondja - Thanks for you interest. Please open issue at - https://github.com/deep-learning-tools/keras if you face any problems.

$ mkdir keras
$ git clone https://github.com/deep-learning-tools/keras ./keras/
$ cd keras/

# MXNet backend code is in keras2_mxnet_backend branch. Check it out.
$ git fetch
$ git checkout keras2_mxnet_backend
$ git pull

# Install Keras
$ sudo python setup.py install

sandeep-krishnamurthy avatar Mar 24 '18 20:03 sandeep-krishnamurthy

Hello, I used all of your instructions but I have this error :

File "/Users/edmondjacoupeau/anaconda/lib/python3.6/site-packages/keras/backend/init.py", line 72, in assert _backend in {'theano', 'tensorflow', 'cntk'}

AssertionError

edmondja avatar Mar 26 '18 10:03 edmondja

Hi @edmondja It looks like you have not checked out keras2_mxnet_backend branch. Can you please confirm? Because, in init.py you should see assert_backend in {'theano', 'tensorflow', 'cntk', 'mxnet'} like this https://github.com/deep-learning-tools/keras/blob/keras2_mxnet_backend/keras/backend/init.py#L72

sandeep-krishnamurthy avatar Mar 27 '18 00:03 sandeep-krishnamurthy

@edmondja - Did you had pre-installed keras (without mxnet backend)? If yes, please uninstall it before running above provided command.

$ pip uninstall keras

sandeep-krishnamurthy avatar Mar 27 '18 00:03 sandeep-krishnamurthy

Thanks it worked

edmondja avatar Sep 05 '18 20:09 edmondja