dgl icon indicating copy to clipboard operation
dgl copied to clipboard

[GraphBolt][CUDA] Cooperative Minibatching hetero bug fixes.

Open mfbalin opened this issue 1 year ago • 6 comments

Description

Towards #7273.

Fixing bugs in the hetero implementation of the Cooperative Minibatching code path that arised when debugging #7807.

NOTE: There is still an accuracy problem which I am working on. There will be at least one more bug fix PR.

Checklist

Please feel free to remove inapplicable items for your PR.

  • [ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • [ ] I've leverage the tools to beautify the python and c++ code.
  • [ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • [ ] All changes have test coverage
  • [ ] Code is well-documented
  • [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • [ ] Related issue is referred in this PR
  • [ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

mfbalin avatar Oct 11 '24 18:10 mfbalin

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot avatar Oct 11 '24 18:10 dgl-bot

Commit ID: bec6f17b97a8e29c2bae958fe34f01b8866079e0

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '24 18:10 dgl-bot

Commit ID: 01b77dcb6ad30a818f4c4645200cd600e1e591c2

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '24 19:10 dgl-bot

Commit ID: 20a35a7f451ec9d63a3f120352d8c17f94c7cf5e

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '24 20:10 dgl-bot

Commit ID: c3e8e89efdbe491837694995876693ab14621b97

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '24 21:10 dgl-bot

Commit ID: 61ca2797848f5d146fc1d1320f9b25e96bb46551

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '24 23:10 dgl-bot