dgl
dgl copied to clipboard
dmlc
[DeprecationWarning] Resolving warnings caused by deprecated function usage.
Description
This PR provides a fix for the following warnings:
/opt/dgl/dgl-source/tools/distgraphlaunch.py:133: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
thread.setDaemon(True)
Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
- [x] I've leverage the tools to beautify the python and c++ code.
- [x] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
Changes
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
@dgl-bot
Commit ID: c3deda62ce6106f6477bc04f3694c7e49e2292a4
Build ID: 1
Status: ❌ CI test failed in Stage [Authentication].
Report path: link
Full logs path: link
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
@dgl-bot
Commit ID: 4e131f234e5b39f48821d9fbd4c4ca1c5556272c
Build ID: 2
Status: ❌ CI test failed in Stage [Authentication].
Report path: link
Full logs path: link
@jermainewang: Sorry, I don't know the minimum torch version number required for thread.daemon = True. However, as we can see here this change is quite old—it was already present by May 7, 2021.
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
@dgl-bot