dgl icon indicating copy to clipboard operation
dgl copied to clipboard

HeteroGraphConv's forward need to modify

Open yfismine opened this issue 1 year ago • 3 comments

🚀 Feature

*mod_args.get(etype,()) and **mod_kwargs.get(etype,{}) in HeteroGraphConv's forward need to be changed to *mod_args.get((stype, etype, dtype),()) and **mod_kwargs.get((stype, etype, dtype),{})

Motivation

For heterogeneous graphs, the parameters of a homogeneous graph cannot be determined only by etype, for example, if there are two kinds of edges (node1,edge1,node1) and (node2,edge1,node1).

yfismine avatar Aug 12 '24 08:08 yfismine

Thanks for filing the issue. Is there a reason for not defining separate edge types (e.g. edge1 and edge2) when the source nodes are of different types in this example? Are there any special considerations to keep in mind?

rudongyu avatar Aug 15 '24 01:08 rudongyu

Yes, I know there are ways to avoid this problem, but I think as a framework itself, there should be no assumptions about the user's source data schema. @rudongyu

yfismine avatar Aug 15 '24 02:08 yfismine

Thanks for further elaboration. I see your point. We’ve added it to our backlog to get prioritized over other feature requests in our roadmap. You are also appreciated to contribute to DGL to get it supported, thanks!

rudongyu avatar Aug 15 '24 03:08 rudongyu