dgl icon indicating copy to clipboard operation
dgl copied to clipboard

[GraphBolt] Default value of `persistent_workers` should be `False`

Open Rhett-Ying opened this issue 1 year ago • 1 comments

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

As gb.DataLoader inherits from torch.utils.data.DataLoader(https://pytorch.org/docs/stable/data.html#torch.utils.data.DataLoader), the default value of persistent_workers should be same. But for now, we're using True while torch uses False.

Depending work items or issues

Rhett-Ying avatar Jan 10 '24 04:01 Rhett-Ying

https://github.com/dmlc/dgl/blob/41a38486a5ed9298093d9f0bc415751269c7d577/python/dgl/graphbolt/dataloader.py#L58

frozenbugs avatar Apr 17 '24 02:04 frozenbugs