dgl icon indicating copy to clipboard operation
dgl copied to clipboard

[NN]: EdgeWeightNorm for tensorflow backend

Open aramakus opened this issue 2 years ago • 15 comments

Description

Support for Tensorflow backend for EdgeWeightNorm and GraphConv

Checklist

Please feel free to remove inapplicable items for your PR.

  • [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • [x] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage
  • [x] Code is well-documented
  • [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • [ ] Related issue is referred in this PR
  • [ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

aramakus avatar Oct 09 '22 08:10 aramakus

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 09 '22 08:10 dgl-bot

Commit ID: e86bcf496d3cdde8a9ff25bc12101b2dbdc0269e

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 09 '22 08:10 dgl-bot

Guys, I am using this functionality for my project and would like to share it with everyone. Please consider review this PR and adding the code to the next release of DGL

aramakus avatar Oct 09 '22 08:10 aramakus

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 10 '22 10:10 dgl-bot

Commit ID: cfa16946eb153c0d1b1a6c5330b26a4dddab814e

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 10 '22 10:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 10 '22 11:10 dgl-bot

Commit ID: 35094c2a7f476ebadf0045532fa0d786e67c2342

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 10 '22 11:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 11 '22 01:10 dgl-bot

@dgl-bot

Rhett-Ying avatar Oct 11 '22 01:10 Rhett-Ying

Commit ID: 053226d9bb2b33d781706f5c3d61d78125b42a37

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '22 01:10 dgl-bot

Hi @aramakus , can you also add unit test for your change to prevent regression when other people touches your code?

frozenbugs avatar Oct 11 '22 01:10 frozenbugs

Commit ID: 053226d9bb2b33d781706f5c3d61d78125b42a37

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '22 02:10 dgl-bot

@aramakus pls fix the lint check failure

Rhett-Ying avatar Oct 11 '22 02:10 Rhett-Ying

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 11 '22 09:10 dgl-bot

Commit ID: ad9560f0c5c3df043281d25d707448dd004b7b9e

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 11 '22 09:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 15 '22 07:10 dgl-bot

Commit ID: afb54b76f368baf6fc8bec74679b64e2503cbff8

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 15 '22 07:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 15 '22 09:10 dgl-bot

Commit ID: 659b9a4b3cd86715f886f2492e7fe6c29d035b24

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 15 '22 09:10 dgl-bot

@Rhett-Ying fixed linting, get no errors for the file I added to @frozenbugs copied unittest from respective pytorch file, no changes but one line

aramakus avatar Oct 15 '22 09:10 aramakus

@dgl-bot

Rhett-Ying avatar Oct 16 '22 01:10 Rhett-Ying

Commit ID: 659b9a4b3cd86715f886f2492e7fe6c29d035b24

Build ID: 9

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Oct 16 '22 02:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 16 '22 05:10 dgl-bot

Commit ID: 1a9e203b8b46458bc5e7f1f8e413002945e86a9f

Build ID: 10

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 16 '22 05:10 dgl-bot

@dgl-bot

Rhett-Ying avatar Oct 16 '22 08:10 Rhett-Ying

Commit ID: 1a9e203b8b46458bc5e7f1f8e413002945e86a9f

Build ID: 11

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Oct 16 '22 09:10 dgl-bot

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

dgl-bot avatar Oct 16 '22 09:10 dgl-bot

Commit ID: 201695cd340abc2db1c78617049e585d7f53c5ef

Build ID: 12

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot avatar Oct 16 '22 09:10 dgl-bot

@aramakus is it possible to verify on your local side before submit commit?

Rhett-Ying avatar Oct 16 '22 09:10 Rhett-Ying

@dgl-bot

Rhett-Ying avatar Oct 16 '22 09:10 Rhett-Ying