Dmytro Kozhevin

Results 76 comments of Dmytro Kozhevin

> It's a bit hard to imagine how the refactored tx set is going to be used, because ledger close logic isn't wired up yet. As a result, I can't...

This PR should be rebased on top of the most recent changes, including the tx set nomination tests that should add some confidence in the refactoring.

> Do you have a testcase that pushes a vnext valid parallel tx set in v22? Parallel tx sets are not supported in v22, but if you meant v23, there...

> Once we deploy a version with v23 xdr, but before the v23 protocol upgrade, it'll be possible to receive a parallel tx set over the wire that we should...

> However, symbols MUST be ascii, so there is no error case there. That's actually not necessarily correct in case if we want to also to be able to handle...

> I wasn't sure if we should get rid of this PR though due to how easy it is to use vs building a query, unless we keep the new...