Dominik Menke
Dominik Menke
@victoraugustolls Interested sure, but I'm currently in short supply of free time :) It might take me until the weekend before I get to update the PR. Looking at #43,...
I've updated the code, however I can't get it to work: At some point, `(pkg/gci/sections).Module` needs to know which module paths are in scope. These are currently is seeded in...
Feel free to take my code and make it work. I currently am quite busy with other things, and don't know when I gain the mental capacity needed to complete...
> automatically check to infer module path works for some cases Hmm... Looking at the code (`ProcessFile` → `processFile` → `newPkg` → `getPkgType` in [`gci.go`](https://github.com/daixiang0/gci/blob/master/pkg/gci/gci.go)), I don't see how that...
I have started an example in #31. Some notes: - The implementation of `type moduleResolver` might be incomplete, I haven't written any tests (yet, I'll add some tomorrow) - I'm...
When moving the `example_test.go` to `example/example_test.go` (and fixing the imports), it reveals that `email.getFrom()` is not valid for an example, as users of this library cannot access unexported functions: https://github.com/xhit/go-simple-mail/blob/289c73008eaf6162fa86a17c769b288a4dce7354/example_test.go#L153-L155
I too have some plans for this weekend. But I've written a small review on [/r/golang (comment)](https://www.reddit.com/r/golang/comments/i5t5f1/gosimplemail_package/g0skojt/), which I might transform into PRs in the coming days.
While preparing #8, I've thought about how to improve the test situation: I was initially planning to install Postfix when running Github Actions, but I think installing mailslurper or MailHog...
I don't like to rely on services on the internet when running automated tests. Network service can fail at any moment (which generates the worst kind of test: flaky ones),...
> Let me know if you want to be a collaborator Sure. I was thinking of developing the `smtptest` module on my fork first create a PR sometime down the...