s3-signer icon indicating copy to clipboard operation
s3-signer copied to clipboard

Use monad-time instead of IO.

Open whittle opened this issue 8 years ago • 2 comments

whittle avatar Jan 13 '17 21:01 whittle

It seems like monad-time is very small, I'm not sure if introducing the typeclass constraint (MonadTime m => m) and an additional dependency is necessary. A whole new dependency just for doing liftIO getCurrentTime seems a tad much. I'm actually considering removing IO altogether, for purity's sake (pass in UTCTime as a parameter). This way if users wanted to use something like MonadTime they could.

Also, depending on another package does introduce potential version conflicts (since all dependency version bounds are managed by social contract), and I don't know how well monad-time is kept up.

dmjio avatar Jan 30 '17 06:01 dmjio

Agree with @dmjio. I don't think it worth it to have extra dependency just to avoid small number of liftIO usages.

chshersh avatar Jun 08 '18 07:06 chshersh