libusb_stm32 icon indicating copy to clipboard operation
libusb_stm32 copied to clipboard

Add CCID support

Open kidbomb opened this issue 1 year ago • 8 comments

kidbomb avatar May 11 '23 05:05 kidbomb

@dmitrystu Any chance of getting this merged?

kidbomb avatar Jun 03 '23 01:06 kidbomb

Sorry for the very late reply. I need to check specs. https://www.usb.org/sites/default/files/DWG_Smart-Card_CCID_Rev110.pdf.

dmitrystu avatar Jun 27 '23 12:06 dmitrystu

Thanks for the review @dmitrystu - those are fixed.

kidbomb avatar Jun 27 '23 21:06 kidbomb

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

dmitrystu avatar Jun 28 '23 15:06 dmitrystu

Just added all messages now

kidbomb avatar Jun 29 '23 19:06 kidbomb

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

kidbomb avatar Jul 09 '23 19:07 kidbomb

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@dmitrystu - Is there anything else you believe is missing? I would like to have this PR merged soon so I can start working on a feature for Flipper Zero

kidbomb avatar Jul 23 '23 18:07 kidbomb

@dmitrystu - reminder

kidbomb avatar Sep 04 '23 02:09 kidbomb