Dmitry Markin

Results 42 comments of Dmitry Markin
trafficstars

Yes, I think I can look into it in a week or so. The one thing I worry about is that these changes will definitely break the API, and I...

It seems the cause for `DialError::WrongPeerId` to contain `ConnectedPoint`, and not `Dialer` or just `Multiaddr` is that [`PendingOutboundConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L89) is based on [`PendingConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L98) also used for [`PendingInboundConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L93). So they both share...

I've implemented the simplest solution in https://github.com/libp2p/rust-libp2p/pull/2793.

> I would be in favor of doing as much as possible at compile time. Would splitting PendingConnectionError be an option? Yes, this seems reasonable, I'll check it.

> Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank...

A note to not forget what is happening here. Before this PR, `Peerset` had a channel for incoming commands sent via `PeersetHandle` (`rx`). These commands were only processes in `poll()`...

Yes, I'm going to continue working on this.

> Btw, based on [this comment](https://github.com/paritytech/polkadot-sdk/issues/556), there may be some quite significant changes to the peerset at some point. Yeah, the race conditions @tomaka is mentioning are also in the...

Superseded by https://github.com/paritytech/substrate/pull/13611. Closing this PR.

> tests are passing for me locally, so not sure what I'm doing wrong... Unfortunately, it's just the way companion system works: polkadot builds know nothing about substrate companions and...