JsonKnownTypes icon indicating copy to clipboard operation
JsonKnownTypes copied to clipboard

Published 20 hours ago • verified publisher icon dmitry-bym

Target multiple frameworks

Open theglobe opened this issue 4 years ago • 2 comments

Add net461 and some frameworks that are supported in Newtonsoft.Json. Only add those frameworks that are compatible with the code as it is.

theglobe avatar Nov 12 '20 16:11 theglobe

I had to remove netcoreapp2.2 from UnitTests because it is not available for some reason. It got the error: Testhost process exited with error: It was not possible to find any compatible framework version The framework 'Microsoft.NETCore.App', version '2.2.0' was not found.

I added the System.ValueTuple NuGet package because the older .NET Frameworks do not have this built in.

I guess that we can add all the frameworks that all supported by Newtonsoft.Json if we add NuGet packages for the features that are missing in the older frameworks. E.g. Linq is not included in net20.

I can make a fresh pull request if needed.

theglobe avatar Mar 30 '21 10:03 theglobe

Now (after merge with latest updates) it fails the test AutoBaseClassSameDiscriminator(auto<BaseClassSameDiscriminator>) for net46, but it works in Visual Studio. Why?

theglobe avatar Apr 07 '21 14:04 theglobe