extension-cookieman icon indicating copy to clipboard operation
extension-cookieman copied to clipboard

TYPO3 12 compatibility

Open svewap opened this issue 2 years ago • 23 comments

Here is my version for T3 12: https://github.com/svewap/extension-cookieman/tree/12-svewap I can make a pull request if you want.

svewap avatar Jan 18 '23 22:01 svewap

Thanks Sven! Yes, please open a PR :) I have branched off 11lts so we can work on v12 together.

There is https://github.com/dmind-gmbh/extension-cookieman/issues/271 which needs to be solved.

I am planning to work next week on it.

jonaseberle avatar Jan 19 '23 10:01 jonaseberle

Hi, any Updates for v12 support? Thank you

weisgerberm avatar Mar 22 '23 21:03 weisgerberm

Hi, any Updates for v12 support? Thank you

Same question. Thanks

zenoussi avatar May 05 '23 11:05 zenoussi

I opened a PR

svewap avatar May 08 '23 10:05 svewap

new Infos?

ingeniumdesign avatar May 25 '23 09:05 ingeniumdesign

Sorry, not much yet.

You can use https://github.com/dmind-gmbh/extension-cookieman/pull/311 which works very well.

What's holding me back is that I would like to have a good solution for https://github.com/dmind-gmbh/extension-cookieman/issues/271 because v12 (or rather typo3/cms-composer-installers:^5) changes the paths of public assets. Most users will not hit that problem (of including files in inject()) and there are ways to work around it.

jonaseberle avatar May 25 '23 14:05 jonaseberle

Overriding of labels via _LOCAL_LANG isn't working anymore. Do we have to use locallangXMLOverride instead?

msollmann avatar Aug 30 '23 12:08 msollmann

@msollmann You mean in the T3 v12 branch?

jonaseberle avatar Aug 30 '23 12:08 jonaseberle

In https://github.com/dmind-gmbh/extension-cookieman/pull/311.

In addition I can only override my own labels (e.g. "group.externalServices"), not existing labels (e.g. "group.marketing") via locallangXMLOverride.

msollmann avatar Aug 30 '23 12:08 msollmann

new Infos?

ingeniumdesign avatar Oct 12 '23 16:10 ingeniumdesign

release for TYPO3 v12 would be nice

Finulin avatar Oct 24 '23 11:10 Finulin

Yes, I agree, but I have not found the time. It would really help if you could test #311 and leave feedback there.

If someone would like to dive into the docs and adjust the examples where needed, that would help as well.

jonaseberle avatar Oct 24 '23 11:10 jonaseberle

@msollmann your translation problem is https://forge.typo3.org/issues/100759

jonaseberle avatar Nov 09 '23 15:11 jonaseberle

Maybe as a christmas present? :)

ingeniumdesign avatar Dec 22 '23 18:12 ingeniumdesign

@ingeniumdesign yes, thank you, please go ahead and test https://github.com/dmind-gmbh/extension-cookieman/pull/323 ;) composer req dmind/cookieman:dev-dev/12lts.

jonaseberle avatar Dec 22 '23 21:12 jonaseberle

The installation worked fine, the output works fine, now I'll test the settings a bit more

ingeniumdesign avatar Jan 06 '24 18:01 ingeniumdesign

The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023.

jonaseberle avatar Jan 22 '24 13:01 jonaseberle

yes, the _LOCAL_LANG TypoScript issue dont work. New Infos?

ingeniumdesign avatar Jun 17 '24 15:06 ingeniumdesign

@ingeniumdesign Are you adding the extensionName in translations like this? {f:translate(key: 'heading', extensionName: 'cookieman')}

jonaseberle avatar Jun 18 '24 07:06 jonaseberle

For me everything works fine with 12 lts. When will you publish official version? I have many projects waiting to get upgraded to 12 lts, where cookieman is the only blocker :(

jankornblum avatar Jul 15 '24 08:07 jankornblum

I am sorry. The docs are still not ready https://github.com/dmind-gmbh/extension-cookieman/pull/323.

You can pin the latest commit with composer req dmind/cookieman:dev-dev/12lts#cc9364f4ba76de706f4af2a3e1be7372aaabba09.

jonaseberle avatar Jul 15 '24 11:07 jonaseberle

Thanks, yes, but I don't like to require a dev-branch in a live project so much ;)

jankornblum avatar Jul 15 '24 11:07 jankornblum

You would pin a commit that you have tested. But ok, I understand what you mean.

jonaseberle avatar Jul 15 '24 11:07 jonaseberle