David Michon

I wrote the code here a couple years ago now. The main motivations: 1) Support for partially staged files. If you have a file with both staged and unstaged changes,...

It would probably be best practice to warn or even error if any paths provided in config files or source code contain back slashes, with a note that they will...

I'd be more a fan of removing the glob handling from `ProjectChangeAnalyzer` altogether and instead take as input a `filterByProject?: Map boolean>` parameter (if not provided, default filter is `(relativePath:...

@elliot-nelson The `filterByProject?: (project: RushConfigurationProject, relativePath: string) => boolean` syntax would work fine for this particular API. Since the per-operation deps scenario is going to need to support querying the...

This looks pretty solid for the current version of Heft; issue is we're pretty close to merging the major refactor of Heft to generalize the scheduling process and that'll require...

Feel free to just leave it open.

There's a TODO in the code just above where you linked to consider using `globalOverrides` to modify the evaluation of workspace-local `package.json` files to be an error: https://github.com/microsoft/rushstack/blob/0c41a82312ebe4c4cf02950c7a000a8ea9de63b8/libraries/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts#L1007-L1009 The basis...

When using `RealContentHashPlugin`, there's also a performance opportunity to not have the original contenthash values be hashes at all, but instead be predictably-shaped unique tokens that can be matched as...

> @dmichon-msft thats not possible.. the hole idea is that you can plug-in/plug-out plugins.. With an appropriate hook in content hash generation, RealContentHashPlugin could override the original content hash generation...

This PR is still marked as a draft, so assumed to not be ready for review.