Push to S3 does not include commits of deleted files
Should update the git-s3-push command to check for deleted files and delete those files in s3. Currently the git-s3-push command does not have a delete functionality when a commit includes deletion of files.
Hi @kevinguamanquispe, apologies I've been busy with other projects but I absolutely didn't mean to leave this unanswered for a year and a half.
I've got plans for a bit of an overhaul of the project ahead of a 0.3 release, so will look into deletion as part of this work. Definitely a good feature to have & it had not crossed my mind that this wouldn't work, so thank you very much for the suggestion.
Happy to pick this one up, looks like the deleted files are returned by the analysis command but we skip the filename if the file does not exist. Propose we instead add the path to the changeset when the file doesn't exist and then delete the S3 object when we "upload" a file which does not exist.
Aye excellent. Haven't looked into the mechanics of this at all but that sounds about right.
Suggest closure RE: PR 😄