RxPM icon indicating copy to clipboard operation
RxPM copied to clipboard

onActivityResult - onRequestPermissionsResult support in Activity/Controller class

Open brcbydr opened this issue 3 years ago • 0 comments

Hi @dmdevgo ,

Sorry for disturbing again but this is important.

RxPm already handles CREATED, BINDED, RESUMED, PAUSED, UNBINDED, DESTROYED. But onActivityResult and onRequestPermissionsResult not supported. Function results like login etc should handled in onActivityResult. And with RxPm, business logic can not be in Controller or Activity, it should be in presenter.

Conductor support onActivityResult is like that: (https://github.com/bluelinelabs/Conductor/blob/develop/conductor/src/main/java/com/bluelinelabs/conductor/Router.java)

Implementation is like below: `class MainActivity : AppCompatActivity() {

private lateinit var router: Router

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
    super.onActivityResult(requestCode, resultCode, data)
    router.onActivityResult(requestCode, resultCode, data)
}

}`

I think it makes sense to support onActivityResult in PresentationModel according to Router. What do you think about that?

Thanks in advance.

brcbydr avatar Jul 20 '20 06:07 brcbydr