Damien Mathieu

Results 196 comments of Damien Mathieu

While this makes sense, it creates a new wrapped tracer every time `Tracer()` is called, which may cause performance issues.

Thank you. I'm personally not super fond of the name `NewDynamicWrappedTracerProvider`, but I'm not finding any. I wonder if we should deprecate `NewWrappedTracerProvider` as well, to avoid keeping both methods...

You're right, `NewTracerProvider` may be good. Let's wait for opinions from other approvers/maintainers about all this.

I wonder if we shouldn't keep the base example simple, to not confuse folks who just get started. How about adding a new example instead of extending the current one?

I'm seeing 3.0.0 being used: ``` open-telemetry/opentelemetry-go› git:(main) grep -Rn 'gopkg.in/yaml.v3' | sed 's#^.*gopkg\.in\/yaml\.v3 \([^\/ ]\+\).*$#\1#' | sort -u ./bridge/opencensus/go.sum:57:gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo= ./bridge/opencensus/opencensusmetric/go.sum:95:gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo= ./bridge/opencensus/opencensusmetric/go.sum:96:gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= ./bridge/opencensus/test/go.sum:96:gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c...

This error indicates Go timed out while waiting for your OTLP provider to respond. It may be a connectivity issue, or within that external service.

That external service is your collector. The error indicates your collector didn't respond in time, so the request was cancelled.

The net/http transport injects attributes from the HTTP request here: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/net/http/otelhttp/transport.go#L113 Within this `HTTPClientAttributesFromHTTPRequest` method, the HTTP URL (which is where I suppose your query string is added) gets appended...

How about an option `WithURLSanitizer(func(*net.URL) *net.URL))` which would give you the original URL, and let you do any sanitization you want?

Actually, the approach in https://github.com/open-telemetry/opentelemetry-go/discussions/2794 may be better for you.