Damien Mathieu

These metrics were removed in the latest versions: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277 It's available starting at `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` version `0.44.0`. It looks like you're on 0.42.0. You should try upgrading.

Ping @Aneurysm9 @hanyuancheung for second review before merge.

Why would someone explicitly not want to record errors? (do we need the option? How about recording the error all the time?)

I think this would need a change in the gin API. We can't create a mutex to change the gin context, as it wouldn't be used within gin itself.

cc @hanyuancheung per code owners.

This hasn't moved yet. The stability of otelhttp, and semconvutil is still not there.

There's a difference between providing backwards compatibility with the provided intrumentation (the attributes remain compatible), and providing a backwards compatible API. The latter is a much bigger constraint.

I've given this a look, and I wonder if it's worth fixing. The template content doesn't seem it can be controlled by an attacker. The dynamic attributes are `TraceID`, `SpanID`...

> This is not only about possible attacks, but also about possible unproperly rendered content. We shouldn't escape the full content, as we output HTML tags on purpose. Only the...

Well, it looks like the `TestStatusError` test needs to be updated to properly reflect those changes.