easy-move-resize icon indicating copy to clipboard operation
easy-move-resize copied to clipboard

Improve calculation of operations-per-second

Open dmarcotte opened this issue 6 years ago • 16 comments

How many move or resize operations we do is currently a hand-tuned static number which is likely not perfect for every user or every machine. We should either smarten it up as the comment there suggests, or possibly make it configurable as suggested here to allow users to tweak it.

dmarcotte avatar Oct 19 '17 18:10 dmarcotte

Unfamiliar with this code, but would this help in detecting the current screen's refresh rate?

https://developer.apple.com/documentation/coregraphics/1454661-cgdisplaymodegetrefreshrate

I'm currently working with a high refresh rate external monitor, and it would be a nice QOL improvement.

brooksilg avatar Dec 30 '20 12:12 brooksilg

I just bought a new monitor with with 3440x1440@144hz, and I can notice a clear diffence when moving windows with the modifier key versus grabbing it in the windows-top-bar. Not really noticable when resizing windows, but especially when moving windows there is a huge difference.

Not that I'm complaining, I'm still going to use this everyday since its part of my workflow, I'm more curios about what "we do" in easy move+resize when we are moving windows, that is not happening when moving them by the top bar. Shouldn't we be able to move windows the same way ?

Thanks again for an awesome application 🥇 👍

patchon avatar May 04 '21 17:05 patchon

Same issue here on 240hz screen. Thanks @brooksilg for suggesting CGDisplayModeGetRefreshRate. I made a commit and (so far) it works perfectly here on MacBook M1 with secondary high refresh rate display. It would be great if someone else could test the changes before PR is raised.

kwketh avatar Jul 28 '21 11:07 kwketh

Same issue here on 240hz screen. Thanks @brooksilg for suggesting CGDisplayModeGetRefreshRate. I made a commit and (so far) it works perfectly here on MacBook M1 with secondary high refresh rate display. It would be great if someone else could test the changes before PR is raised.

I tested with my M1 mac pro and external monitor philips 328E with 60hz refresh rate. It works quite well.

fbirlik avatar Aug 01 '21 23:08 fbirlik

Same issue here on 240hz screen. Thanks @brooksilg for suggesting CGDisplayModeGetRefreshRate. I made a commit and (so far) it works perfectly here on MacBook M1 with secondary high refresh rate display. It would be great if someone else could test the changes before PR is raised.

Do you have a build for this that one just could test, if not, could you provide one ?

patchon avatar Aug 25 '21 10:08 patchon

Here is a debug version with the changes made by @kwketh — works well and feels more responsive on my M1 + 60Hz external monitor.

I'd say go ahead and open a PR :)

easy-move-resize-9868b54-debug.zip

brooksilg avatar Dec 20 '21 17:12 brooksilg

Here is a debug version with the changes made by @kwketh — works well and feels more responsive on my M1 + 60Hz external monitor.

I'd say go ahead and open a PR :)

easy-move-resize-9868b54-debug.zip

Is this built for the M1's ? I can not execute this executable on my MBP 13, 2015.

patchon avatar Jan 07 '22 23:01 patchon

Here is a debug version with the changes made by @kwketh — works well and feels more responsive on my M1 + 60Hz external monitor. I'd say go ahead and open a PR :) easy-move-resize-9868b54-debug.zip

Is this built for the M1's ? I can not execute this executable on my MBP 13, 2015.

Ah, apparently so — this debug build was built and has only been tested on M1s

brooksilg avatar Feb 03 '22 22:02 brooksilg

I just tested the debug build from @brooksilg with changes made by @kwketh on my M1 and it definitely feels more smooth and responsive now, on both the built-in monitor as well as external monitors!

sshock avatar Feb 26 '22 09:02 sshock

This is a great discussion, thanks everyone. Would definitely welcome a pull request here if someone wants to polish and send.

dmarcotte avatar Apr 18 '22 19:04 dmarcotte

I confirm that this easy-move-resize-9868b54-debug.zip is better on my MBP14" M1 Pro. Can someone please submit a PR, so we can have the latest features with this?

sbissonnette avatar May 02 '22 21:05 sbissonnette

Hello, Did someone noticed slow or laggy move + resize only on specific apps?

I'm running on M1 max and it always ran smoothly since I installed it 5 months ago. However since a few days I have a weird behavior on Chrome: the resize & move is very (very) slow while it runs well with all other apps. When I restart Chrome it becomes smooth again, but after browsing a few websites, it becomes again very slow.

I'm not sure if it's because of last update from easy-move-resize or from Chrome. Should I open another issue?

MattKetmo avatar May 09 '22 19:05 MattKetmo

Extremely glad to have found this app. I've immediatly started using it all the time on a 2015 MBP with 2x 120 Hz monitors. Only improvement i can think of so far is the slight 60 Hertz-y stutter.

Tabiskabis avatar May 10 '22 22:05 Tabiskabis

@MattKetmo No I dont have any issues that is software specific. But I also use this version which improve performance a bit more easy-move-resize-9868b54-debug.zip (But doesnt include latest feature).

sbissonnette avatar May 10 '22 23:05 sbissonnette

I've never written objective-c in my life but this patch doesn't seem to account for two things:

  • Building on intel straightaway I get an error indexing into the list of modes with CGMainDisplayID. Once fixing that:
  • https://developer.apple.com/documentation/coregraphics/cgdisplaymode/1454661-refreshrate can be 0? Some other display stuff to support it seems.

Might have a look at this tomorrow if anyone has some pointers that would be awesome.

LiamKearn avatar Jul 19 '22 13:07 LiamKearn