Dmytro Maluka
Dmytro Maluka
> Storing data in bytes and storing the same data in the ints? I can understand replacement but addition? Why? As I said, this is just an initial rough idea....
> but the feature suffering the most from it is the highlighting...at least from end user perspective. I don't think so. Try it: create a file `long.txt` with a long...
@niten94 I can also see this bug (and don't see it without this PR).
> This issue concerns not just the edited files themselves, but also other files that micro may modify: settings.json, bindings.json, backups and so on. This actually happened to me today...
I see other people have also already encountered this problem: https://github.com/zyedidia/micro/issues/1916
More or less. We might need to figure out how to do it fully reliably (or as reliably as possible), e.g. what if the file is a symlink or a...
There are some 3rd-party packages e.g. [renameio](https://github.com/google/renameio) but I haven't looked into that deeply.
Yes and no. If for example the user's file is a symlink, and we just rename() it with our temporary file, the user's file silently becomes a regular file instead...
> Also, I don't agree with the idea that leaving a temporary file upon failure is bad. Sure, we should keep the temporary file upon a failure, since it contains...
BTW it should be worth looking how Vim handles the issue when saving files (and analyzing whether what Vim is doing is reasonable). At first glance it looks like it...