dmakarov

Results 47 comments of dmakarov

> I get the same problem with [GPL](https://github.com/solana-labs/governance-program-library), tests work with` 1.14.18` but fail with `1.16.1 ` How to run GPL tests? Is running `cargo test` sufficient to reproduce the...

I work on updating platform-tools to rust 1.72. Current plan is to release updated platform-tools by the end of this week, but it may take longer.

> > I work on updating platform-tools to rust 1.72. Current plan is to release updated platform-tools by the end of this week, but it may take longer. > >...

Indeed, we already added SubtargetFeature "solana" to the BPF target in llvm. All our llvm changes are enabled only when the feature is enabled by a command line option. I...

This is a good point. Yes the solana forks will be used as buffers for changes/fixes that eventually should be submitted to upstream.

> #### Make sbf-solana-solana work like the upstream bpf*-unknown-none targets > We could have `sbf-solana-solana` do the same thing, produce LLVM IR then invoke a tool (maybe even a fork...

We currently have LTO disabled because with LTO incorrect BPF code is produced in some cases (need investigation and fixing). The default optimization level in our toolchain is O3 (which...

If I remember correctly, running [solana/scripts/build-downstream-projects.sh](https://github.com/solana-labs/solana/blob/master/scripts/build-downstream-projects.sh) should fail on some test if `-C lto=no` is not added to `RUSTFLAGS` environment variable. We automatically add this option in cargo-build-bpf https://github.com/solana-labs/solana/blob/1fae3d24de820069417414b900a7efee9e82ecf7/sdk/cargo-build-bpf/src/main.rs#L518-L527

We had rust standard libraries as a separate repository https://github.com/solana-labs/rust-bpf-sysroot It was difficult to update to new versions of rust. I think it would be better if we maintain the...

If we go on the path of separating std and publishing it on crates.io, rust-std-sbf-solana-solana won't be available for installation via rustup as a component, correct? I guess, it's not...