Daniel Magliola

Results 41 comments of Daniel Magliola

Another potential option would be to have one file per process, rather than one file per process/metric. This doesn't fundamentally solve the issue, but it makes it orders of magnitude...

Hello @jeremiahishere! Glad to hear you're interested in this feature and would have time to contribute to it! There hasn't been any movement on this, and there are things we...

> Switch DirectFileStore to use file per process Yes!!! So there are two reasons I haven't done this... One is "fear": maybe that'll actually be slower / worse in some...

> I think you're suggesting creating a new gem to offer a custom [data store](https://github.com/prometheus/client_ruby#data-stores) that can store and process the data Exactly that! Take this for example: https://github.com/gocardless/prometheus-client-ruby-data-stores-experiments That's...

Right now we support all aggregation modes in all metric types. We default to the sensible thing (sum for counters), but I don't see a reason not to cater for...

To clarify, I'm not saying not to make aggregation part of the binary format. I'm happy to do that if we find a good way. I'm just suggesting that we...

I may be way off here, but I'd measure before going too hard on how many bits/bytes this takes... Compared to the space taken up by the labels, this is...

Yes, please! Is this a reasonably easy change to make for someone that doesn't know Nandi? I'd be happy to contribute this

Could you make your life slightly easier by going: `change_column :table, :foo, type: :text, assert_empty_table: true` And then the validator already knows it's safe because you're going to assert, and...