terraform-provider-libvirt icon indicating copy to clipboard operation
terraform-provider-libvirt copied to clipboard

Published 20 hours ago • verified publisher icon dmacvicar

Add Combustion resource to use instead of the ignition one

Open cbosdo opened this issue 1 year ago • 2 comments

Since combustion is very similar to ignition, add another resource based on the ignition one, just adding a flag to disable the JSON unmarshalling error.

cbosdo avatar Feb 12 '24 16:02 cbosdo

I am ok with the hack, but I think a comment above the flag should make explicit what we are doing.

dmacvicar avatar Mar 19 '24 21:03 dmacvicar

I am ok with the hack, but I think a comment above the flag should make explicit what we are doing.

Sorry for the late reply. I added a comment on the Combustion member of the definition. I hope that's what you meant.

cbosdo avatar Apr 17 '24 07:04 cbosdo

Integration tests are broken after I merged:

image

dmacvicar avatar Aug 16 '24 08:08 dmacvicar