go-dnscollector icon indicating copy to clipboard operation
go-dnscollector copied to clipboard

TIMEOUT "answers" logged as CLIENT_QUERY

Open flz opened this issue 2 years ago • 3 comments

I realize that TIMEOUT are not really answers but would it make more sense to log them as CLIENT_RESPONSE than CLIENT_QUERY?

flz avatar May 07 '23 03:05 flz

I should also make changes to timestamp (arrival time of the query + timeout) Makes sense if I do that.

dmachard avatar May 07 '23 06:05 dmachard

The complexity here is that if you're receiving the response after the timeout has been reached, you will end up with more CLIENT_RESPONSE than CLIENT_QUERY, which isn't right either.

flz avatar May 09 '23 17:05 flz

You're right,

  • perhaps we can add a new setting to let the choice of CLIENT_RESPONSE or CLIENT_QUERY
  • for your last point, If you have some suggestions :)

dmachard avatar May 10 '23 16:05 dmachard