gh-dash icon indicating copy to clipboard operation
gh-dash copied to clipboard

[BUG] key binding shift+down and shift+up do not work

Open TLINDEN opened this issue 4 months ago • 3 comments

I want to use shift+down and shift+up to scroll through the preview pane. But gh-dash does not respond to those keys, although bubbletea defines them.

To Reproduce

keybindings:
  universal:
    - key: "shift+down"
      builtin: pageDown
    - key: "shift+up"
      builtin: pageUp

Visit an issue or pr with a larger text in the preview pane and press thos keys. Nothing happens.

Expected behavior I can use other simple keys like D and U (which is my current workaround), but I'd expect bubbletea key combos to work.

Desktop (please complete the following information):

  • OS: Ubuntu 25.04
  • gh-dash: v4.16.1, checksum: h1:bWsjVHapSlZChre33870cpKLJUuFB63D330ZCcytYCs=
  • Terminal: xfce4-terminal
  • WM: swayfx 0.5.2 (based on sway 1.10.1)

TLINDEN avatar Aug 29 '25 18:08 TLINDEN

I'm getting same issue with ctrl+j / ctrl+k. Also, it wasn't until I found this issue that I was aware of builtin being the property name to use for rebinding keys... maybe that could be updated in the docs somewhere as well?

englut avatar Sep 11 '25 18:09 englut

Oh yeah i need to get to that. But contributions are welcome

dlvhdr avatar Sep 11 '25 18:09 dlvhdr

Interestingly, ctrl+down and ctrl+up are working fine 👍

TLINDEN avatar Sep 14 '25 19:09 TLINDEN