gh-dash icon indicating copy to clipboard operation
gh-dash copied to clipboard

[BUG] Merge does nothing, no output in debug mode either

Open qmacro opened this issue 1 year ago • 1 comments

Describe the bug Running version 4.7.3:

# /home/user
; gh dash --version
gh-dash version dev
goos: linux
goarch: amd64
module version: v4.7.3, checksum: h1:YeXNIqa8Tr2o688xLZAckpnr095AKRFMCh7TPeTR9O4=

I can find, view and successfully add a comment to a PR but when I try to merge the PR (which is mergeable), nothing happens at all. No visible errors or any other sign in the UI.

Running with the --debug option, and tailing the debug.log file, also shows nothing:

# /home/user
; tail -f debug.log
1:07PM DEBU <data/prapi.go:220> Fetching PRs query="is:open author:@me" limit=20 endCursor=<nil>
1:07PM DEBU <data/prapi.go:220> Fetching PRs query="is:open involves:@me -author:@me" limit=20 endCursor=<nil>
1:07PM DEBU <data/prapi.go:225> Successfully fetched PRs query="is:open review-requested:@me" count=1
1:07PM DEBU <ui/ui.go:505> Task finished id="fetching_prs_2_2024-11-19 13:07:44.810435762 +0000 UTC m=+0.125298334"
1:07PM DEBU <data/prapi.go:225> Successfully fetched PRs query="is:open author:@me" count=6
1:07PM DEBU <ui/ui.go:505> Task finished id="fetching_prs_1_2024-11-19 13:07:44.809598887 +0000 UTC m=+0.124461418"
1:07PM DEBU <data/prapi.go:225> Successfully fetched PRs query="is:open involves:@me -author:@me" count=12
1:07PM DEBU <ui/ui.go:505> Task finished id="fetching_prs_3_2024-11-19 13:07:44.810585512 +0000 UTC m=+0.125448043"
1:07PM DEBU <ui/ui.go:163> Key pressed key=l
1:07PM DEBU <ui/ui.go:163> Key pressed key=l
1:08PM DEBU <ui/ui.go:163> Key pressed key=p
1:08PM DEBU <ui/ui.go:163> Key pressed key=p
1:08PM DEBU <ui/ui.go:163> Key pressed key=m

(nothing appears after this line)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Involved' tab
  2. Select a PR
  3. Hit 'm' for merge
  4. See nothing happen

Expected behavior Some indication that either the merge was carried out, or that something went wrong.

Screenshots

Screenshot 2024-11-19 at 13 09 51

Desktop (please complete the following information):

  • Running in a Linux (Debian 12) based container, via Docker Desktop, on macOS. This is my normal working environment for everything, i.e. I've not set the container up for looking at gh-dash.

Please note this is very likely to be a problem with me, not gh-dash. Thanks! :-)

qmacro avatar Nov 19 '24 13:11 qmacro

I found the confirmation prompt really hard to notice in this colour scheme.

Image

You don't get that at all?

(Separately I found the confirmation text implies hitting enter would do the merge, but actually it requires y or Y)

cakemanny avatar Apr 29 '25 07:04 cakemanny