gh-dash icon indicating copy to clipboard operation
gh-dash copied to clipboard

[BUG] repoPaths are case sensitive

Open Sanix-Darker opened this issue 8 months ago • 0 comments

Describe the bug The repoName should lower down along side withthe given path because TheAuthor/repo1 seems not equal to Theauthor/repo1, which is not true because those two redirect to the same project on github.

To Reproduce Steps to reproduce the behavior:

  1. Just set a repo name in the repoPath section with MAJ or MIN, dash will crash when you try to run a custom command saying the path for the given repo is not available.

Expected behavior Should not crash an resolve the repo(path and name) even with upper or lower cases + more details on the error maybe ?

	if !ok {
		return func() tea.Msg {
			return constants.ErrMsg{Err: fmt.Errorf(
				"Failed to find local path for repo %s from path: '%s'",
				repoName, repoPath,
			)}
		}
	}

https://github.com/dlvhdr/gh-dash/blob/555c5d9f5671b8fdf77a2dca9056ef8a8e86a316/ui/modelUtils.go#L112

Screenshots Screenshot from 2023-10-11 09-03-18

Desktop (please complete the following information):

  • Not Os related

Sanix-Darker avatar Oct 11 '23 07:10 Sanix-Darker