gh-dash
gh-dash copied to clipboard
Ask for confirmation before closing PRs
Is your feature request related to a problem? Please describe. Hey, very slick tool ✨ Could see this staying open all day every day on my terminal.
However, in just playing around with it for a couple minutes, I already accidentally closed a pull request of a teammate of mine while in the "needs my review" tab. Pretty awkward.
Describe the solution you'd like
There should be an explicit confirmation action before performing a PR close/open (potentially any state manipulation?) It is just way too easy to accidentally hit x and next thing you know you've closed someone else's PR without meaning to
Describe alternatives you've considered Disable it altogether via configuration? Personally, there is very little chance I will ever close someone elses PR through my terminal, but that might just be me
Additional context N/A
Yeah that's a good idea. Would love a PR for this. It would require to implement a confirmation style input, which is also need to implement #175