David Lurton

Results 47 comments of David Lurton

Potentially, also terminology could be revisited. i.e. drop the existing `Visitor` classes and rename/refactor `Converter` to `Visitor`. I am not opposed to breaking API changes myself if they need to...

In principle, I would not be opposed to combining `Visitor`, `VisitorFold` and `Converter`. You will have to weigh the cost of breaking API changes and updating the PartiQL codebase and...

> I see how Converter is an interface, so you have to implement them all. Was that intentional to enforce? Yes. This works well in a number of scenarios. For...

@RCHowell If you do make changes to these generated visitors, please make sure to include me in any design doc reviews / PRs, etc. I am the original author of...

I believe this would also be a way to implement the feature being described in #58.

Amended the title and description of this issue by replacing the term "import" with "include" to reflect this decision that was made during the review of #74.

In https://github.com/partiql/partiql-lang-kotlin/pull/1592, I didn't account for dotted targets in https://github.com/partiql/partiql-lang-kotlin/pull/1592 either, darnit. `(record dml_target (identifier identifier))` should have been `(record dml_target (* (identifier identifier) 1))`.