Missing license hint in ReadMe and files from project.

[Naoghuman]

Missing license hint in ReadMe and files from project.

a) When I read the ReadMe I see some badges from 'img.shield.io'. The badge for the license is there missing :) . b) No resource, either java file have an license hint. I see that the files in the package com.dlsc.preferencesfx.formsfx.view.renderer have a license hint for the apache 2.0.

I can prepare a PR if you are interested?

[martinfrancois]

Hi @Naoghuman,

I think we don't have it there since there is now a feature on Github to define the license. If you have a look at the "Code" tab here, next to "11 contributors" it says: "Apache-2.0". I think this should be sufficient and since this is a universal way to specify the license on github, it should be clear. Also you can see that in the root of the repository there is a file called "LICENSE". I think having a badge and especially having it in the header of each file would be way overkill.

You are correct though that it's present in FormsFX components, but I think this is mostly because the original code of FormsFX has it and probably FormsFX was created when github didn't have this feature yet, although I'm not sure on that one.

Thanks anyways for the suggestion! François

[Naoghuman]

I know this new feature where can readed what a license make and not. Its the first time that this feature is an argument to not include an advice in the sourcefiles :)

So when the license advice not needed why don't cleanup these files which have momentary one? So the projects files are consistence...

[martinfrancois]

The project files are consistent - in a way that the license header included in the files taken and modified from the FormsFX project is kept. I think if we would remove it here, we probably would need to do it in FormsFX too, to maintain consistency. Ultimately, this is to be decieded by @dlemmermann. What do you think?