capsicum-rs

capsicum-rs copied to clipboard

asomers

Release 0.3.0, please

7

After PR #50 and #51 merge, would you please build a new release? That will allow me to satisfy "cargo audit" on downstream crates.

asomers

The `IoctlsBuilder::new` method takes one ioctl command. Additional ioctl commands can be supplied with `IoctlsBuilder::add`. This is inconsistent in two ways: * The first ioctl command is added with a...

asomers

Right now the `flags` argument to `Directory::open_file` is a plain int. It would be much Rustier to define it as a bitflags type. The Nix crate has many such examples.

asomers

`Directory` is the only public symbol that must be imported from a submodule. And it isn't a very interesting submodule. I suggest exporting Directory from the crate's root, for consistency's...

asomers

Use I/O Safety

1

Rust 1.63.0 introduces I/O safety. `RawFd` (just a wrapper around `i32`) gets replaced by `OwnedFd` to track file ownership. It's a very nice improvement, and I think capscium should take...

asomers

Rust 1.77.0 introduces cstr literals. We should use this feature and eliminate the cstr crate. https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#c-string-literals

asomers

They never offered any real advantage over using FcntlsRights and FileRights directly, other than providing symmetry with IoctlsBuilder.

asomers

Replace hard-coded constants with definitions in libc

1

Depends on https://github.com/rust-lang/libc/pull/3628 Fixes #70

asomers

Replace the Fcntl enum with values from libc

2

Replace Fcntl::GetFL with libc::F_GETFL, etc.

asomers