Daniel Pierce

Results 30 comments of Daniel Pierce

This appears to have been resolved as part of #1485, which still needs to be released.

I'm continuing to review this and make sure we have a dassie config that uses Freyja.

I think we're getting close. I feel like the changes in dassie to enable Freyja need an on/off env toggle.

@tpendragon can chime in too, but my understanding is these convenience methods are purposefully not available in order to follow the data mapper pattern. See https://github.com/samvera/valkyrie/wiki/Saving-a-resource#persistence

If we adopt tamsin's suggestion, I want them to live in a separate included file so it's clear which methods are implicated, and add rubocop rules to prevent their use...

We're gearing up for a major release anyways, so my vote is to proceed.

Let's make sure it is noted in the release notes and added to the newly minted [upgrade guide](https://github.com/samvera/hyrax/wiki/Upgrade-Hyrax-4.x-to-Hyrax-5)

I agree with Ben here. In applications with lots of records to be displayed here, making a few thousand individual solr requests is not going to be performant. An overhaul...

I don't see a problem with moving away from using the `Hyrax::AdminSetCreateService::DEFAULT_ID` constant and having it always be set by the Hyrax config. Somewhat related to this, I wonder if...

I like this. I was surprised to still need to customize the presenter (and other files) when we have the metadata schema yaml files in place. However, I'm going to...