dlorenc

Results 347 comments of dlorenc

+1 to the idea. I think most can be handled with the standard rekord type but with custom index keys for searching.

Is this one fixed? I think the harness tests made it in and cover most of this.

Closing, we can reopen or open new ones if we missed anything.

Dropping from GA per maintainers chat.

I think @imjasonh already did the interface/registration thing: https://github.com/sigstore/sigstore/blob/main/pkg/signature/kms/gcp/client.go#L43

> @haydentherapper and I discussed something like this quite recently here: [sigstore/fulcio#496 (comment)](https://github.com/sigstore/fulcio/pull/496#discussion_r844185497) > > > Nit: I prefer having imports with side effects (e.g loading database drivers and plugins...

> @dlorenc we can make them their own modules in-place here? idk, does that make semver mad?