Dave Longley comments

Results 335 comments of


                                            Dave Longley

Fix issue where encrypted data was not decryptable

Prepending the leading `0x00` byte is correct according to [PKCS#1 v2.1](https://www.ietf.org/rfc/rfc3447.txt). This is a change from 2.0, but it should be backwards compatible. So the patch in this PR would...

Fix issue where encrypted data was not decryptable

The latest, [PKCS#1 v2.2](https://tools.ietf.org/html/rfc8017#section-7.1.1), also prepends a `0x00` byte to the encoded message.

Fix parsing content of PKCS#7-message if it is DER-data

I may have misread these changes ... looking back over it again.

Min supported tls version

Related to #283.

CMS/PKCS#7 support for RSAES-OAEP

Thanks, stesie, this is great. It will take some time for me to review this and the MGF1 API changes -- I want to ensure they work with the direction...

CMS/PKCS#7 support for RSAES-OAEP

@wottpal, This PR needs to be rebased because it has conflicts. @stesie, are you able to rebase it? If not, @wottpal, could you submit a new PR that has the...

Load html

Thanks @gkellogg! This is great. A few minor changes needed plus one architectural thing we need some feedback from @davidlehn on (regarding how to pull in a dom parser).

@context: null doesn't work, but @context: [null] does

@davidlehn -- can you see if this is fixed and close if so?

Add feature to throw error when unmapped elements are dropped during processing

Partially supported with `expansionMap` and `compactionMap` here: bcae96153a1e7da6669eeaf25f856ab93d833cd8 Still need something for `toRDF`.

Add feature to throw error when unmapped elements are dropped during processing

Specifically, when converting to RDF, relative URIs are dropped and this should be handled by another map or similar mechanism.