react-flexbox-svg icon indicating copy to clipboard operation
react-flexbox-svg copied to clipboard

Upgrade to React 15 and a bit of cleanup

Open paulmelnikow opened this issue 7 years ago • 6 comments

Thanks for this useful library! I'm looking forward to using it in my project.

It's in good shape for React 15, which is great. 👍

I made a couple changes to the dependencies, kept out some extraneous files, and removed indirection through the index file.

paulmelnikow avatar Mar 01 '17 15:03 paulmelnikow

I may take this in a different direction. To improve encapsulation, I'm moving responsibility for the child's flex style from the parent component to the child component. In my use case the data injected into the component determines the layout, and since the child contains the rendering logic it's the natural place to put the style logic as well.

If the parent wants to affect the style, it should do so using props. The previous behavior can be accomplished easily enough with a wrapper component.

I'm experimenting with a computeStyleFromProps function injected as a parameter when the HOC is applied. Though, I'm not convinced this is flexible enough.

Are you still interested in this project? Might you be interested in collaborating on these changes? @dlmanning

paulmelnikow avatar Mar 02 '17 14:03 paulmelnikow

Eh, here's what I've got: https://github.com/paulmelnikow/react-flexbox-svg

paulmelnikow avatar Mar 03 '17 21:03 paulmelnikow

@paulmelnikow : Yes! I haven't used this module in a while, but it was a labor of love when I wrote it. I'll look over what you've done this weekend.

Thanks for your interest!

dlmanning avatar Mar 03 '17 21:03 dlmanning

Awesome. Curious your thoughts! I wouldn't have attempted this if I hadn't found your work.

There are a couple parts that I feel could be made clearer with your help. I couldn't understand the flow of control between FlexContext and FlexBox (which I called Layoutable).

paulmelnikow avatar Mar 03 '17 22:03 paulmelnikow

Hi there! I'd love to drive this forward. Would you be interested in transferring the react-flexbox-svg package over to me so I can publish my updates?

I'm paulmelnikow on npmjs.

paulmelnikow avatar Nov 19 '18 19:11 paulmelnikow

@dlmanning Hi! I thought I'd reach out and ask about this. Would you be up for adding me on npmjs so I can publish my updates under the original name?

paulmelnikow avatar Dec 17 '18 19:12 paulmelnikow