swmmr icon indicating copy to clipboard operation
swmmr copied to clipboard

Published 20 hours ago • verified publisher icon dleutnant

Green-Ampt parameters

Open maxbekas opened this issue 6 years ago • 9 comments

Could you share the example of supplementary R objects for Infiltrarion for Green-ampt method? All the examples include only Horton's parameters Thanks!

maxbekas avatar Apr 24 '19 12:04 maxbekas

Or maybe the right name for columns in .shp files for Green-Ampt.

maxbekas avatar Apr 24 '19 12:04 maxbekas

Well, I'm about to go on vacation. So things may take a while.

dleutnant avatar Apr 24 '19 12:04 dleutnant

Have a nice rest!

maxbekas avatar Apr 24 '19 14:04 maxbekas

Are there any updates on this? I just found that read_inp doesn't seem to support the Modified Green-Ampt equations. Works fine when I switch over to Horton.

Thanks

jjsoper avatar Dec 18 '20 16:12 jjsoper

The Modified GA was added in 2015 and in some respects is the best infiltration option

Build 5.1.010 (08/05/15) Engine Updates:

  1. A modified version of Green-Ampt infiltration (MODIFIED GREEN AMPT) was added that no longer redistributes upper zone moisture deficit during low rainfall events. The original authors of SWMM's Green-Ampt model have endorsed this modified version. It will produce more infiltration for storm events that begin with low rainfall intensities, such as the SCS design storm distributions.

dickinsonre avatar Dec 18 '20 18:12 dickinsonre

This looks to be a simple fix in the code. The modified Green-Ampt column headers are the same as Green-Ampt (see SWMM user manual page 290). Simply duplicating the headers in the parse_section.infiltration options and renaming to modified_green_ampt does the trick.

https://github.com/jjsoper/swmmr/blob/21b91d978ae9a03ebedd1e37a9984ad5e154a01a/R/parse_section.R#L177-L196

@hsonne I think your latest mydev branch is the most up to date (handles large .out files and seems to support R 4.02) and is what I have been using. https://github.com/dleutnant/swmmr/issues/48#issue-653099692

jjsoper avatar Feb 04 '22 14:02 jjsoper

@jjsoper I changed parse_section.infiltration() according to your suggestion and did some cleaning (see https://github.com/hsonne/swmmr/pull/5/files). Would you like to test this by installing swmmr from my "support-modified-green-ampt" branch?

remotes::install_github("hsonne/swmmr@support-modified-green-ampt")

hsonne avatar Feb 04 '22 23:02 hsonne

@hsonne yes will do. Heading out for vacation but will test when I get back (2/14). Thanks!

jjsoper avatar Feb 05 '22 01:02 jjsoper

@hsonne can confirm that this works on my computer. Thanks!

jjsoper avatar Feb 15 '22 21:02 jjsoper

The corresponding changes are now available on the dev branch of this repository. You can install the package from there with remotes::install_github("dleutnant/swmmr@dev").

hsonne avatar Jan 19 '23 23:01 hsonne