patchwork icon indicating copy to clipboard operation
patchwork copied to clipboard

'pending' test result state should be at the highest priority at the revision level

Open dlespiau opened this issue 9 years ago • 2 comments

Right now, when deriving the test result state of the revision from the all tests results, we do a max([t.state for t in test_results]). So if we have two test results, one 'pending' and the other 'success', we'll derive that the revision has the 'success' state.

It's misleading to do so. If we have a pending test, we should wait until it's finished to give more indication to the user (the revision level test result will be displayed in the list of series). In the case above, the revision test state should be 'pending', indicating that we are still waiting for a test to finish before we can conclude anything else.

dlespiau avatar Feb 09 '16 01:02 dlespiau

If I understand this correctly, the 'pending' status will be shown in the list of series. If that's the case, we'll need to show it in the 'series tests' page too. It could look something like this

http://belenbarrospena.github.io/patchwork-redesign/index.html http://belenbarrospena.github.io/patchwork-redesign/tests.html

I somehow prefer the label 'in progress' than 'pending': I find it clearer (although it is longer). But feel free to pick your favourite one.

belenbarrospena avatar Feb 09 '16 11:02 belenbarrospena

That's exactly it, I'll 'in progress' as well.

dlespiau avatar Feb 09 '16 11:02 dlespiau