Damien

Results 113 comments of Damien

Hi, I'm doing the low level part of this, framing on top of the HostVM serial link so the proxy can recover the start of a frame when reconnecting to...

Unfortunately, the work has been wiped out when I dd'ed /dev/urandom to my hard-drive :/

does it make sense to you to downgrade this with "all exported functions"? I think that's what goling checks for. I don't think having a header for all function is...

PR #360 has a compromise: have golint be happy, ie all exposed symbols are documented. This can be abused a bit a main packages, hiding all symbols in those. A...

@jodh-intel golint passes and now enforces that every exposed symbol must be documented. I think that's an acceptable trade-off and certainly widely accepted in other go project. Happy to close...

_From @jodh-intel on November 10, 2016 17:33_ There still seem to be public functions that are not documented (for example `protocol.Serve()`).

golint is happy because they are in the main package, not a package that can be imported from elsewhere.

Yes, absolutely! That's one of the idea behind making the proxy the central place for logging messages, it'd then be possible to parse that output to capture timings or even...

I'd like all logs to go to the proxy at some point so we can have a global view from there: https://github.com/clearcontainers/proxy/issues/35 I think I'll have time to implement that...

Using a file seems worse to me: - In both cases, one needs to open a fd, either for a file or a domain socket. Anything that happens before that...