vpn-slice icon indicating copy to clipboard operation
vpn-slice copied to clipboard

--domains-vpn-dns support for Linux (via resolvconf)

Open onehalf3570 opened this issue 3 years ago • 9 comments

quick-tested under archlinux with openresolv (3.12.0-1) and dnsmasq (2.85-1)

onehalf3570 avatar May 27 '21 19:05 onehalf3570

Oh, I thought that approval means automatic merging and closed this PR, but apparently this is not how the workflow goes - reopening.

onehalf3570 avatar May 31 '21 10:05 onehalf3570

This is very useful for easily setting up targeted DNS on Ubuntu. Hopefully it will get merged :)

alexkaratarakis avatar Aug 31 '21 09:08 alexkaratarakis

Sad that this PR did not make it into the recent v0.16 release.. will someone with write access take a look at the conflict?

hgtok avatar Dec 16 '21 07:12 hgtok

Any updates on this one?

allanadair avatar Apr 25 '22 07:04 allanadair

@gmacon anything blocking this merge?

YngveMolnes avatar May 24 '22 11:05 YngveMolnes

@YngveMolnes, this PR has merge conflicts and needs to be rebased before it can be merged.

@onehalf3570, can you please rebase this on the latest master or let us know that you don't have available capacity to do that?

Also, I think of myself as owning the macOS support, so I wasn't going to merge this since it isn't macOS related, though I'm happy to provide eyes on any PR. @dlenski, please let me know if you want me to go ahead and merge other PRs, too.

gmacon avatar May 24 '22 15:05 gmacon

@onehalf3570, can you please rebase this on the latest master or let us know that you don't have available capacity to do that?

Yep, will do.

onehalf3570 avatar May 27 '22 22:05 onehalf3570

@onehalf3570, can you please rebase this on the latest master or let us know that you don't have available capacity to do that?

Yep, will do.

I went ahead and rebased it for myself. https://github.com/pickardjoe/vpn-slice/tree/feature--domain-vpn-dns--linux-support

pickardjoe avatar May 31 '22 13:05 pickardjoe

@onehalf3570 pls advise if it been rebased yet? The branch conflict is still appearing on my screen..

hgtok avatar Jul 28 '22 15:07 hgtok

#118, which is a reabased version of this PR has been merged, so I'm going to close this now.

gmacon avatar Sep 19 '22 01:09 gmacon