Da Li (李达) comments

Results 118 comments of


                                            Da Li (李达)

[llvmlite] Support opaque pointers.

For a record: I guess this PR could be surpassed by #1042?

[llvmlite] Support opaque pointers.

Yeah, totally understandable.

remove all refops if a basic block is a raising block

Hi, @sklam. This is another small improvement for ref-pruning. It can enjoy your review! Thanks

remove all refops if a basic block is a raising block

Hi, any comment for this PR and the related issue? cc @esc

remove all refops if a basic block is a raising block

Yeah, I will make up one test case for it ASAP (probably tmr). In theory, it will definitely help the performance since we prune more atomic refcounts.

remove all refops if a basic block is a raising block

> @dlee992 I suppose this ought to make typed.List faster? If so, do you have any benchmarks to share? Actually, this one could be quite tricky to prove, and I...

Add basic infra required to move Numba to NewPassManager

Thanks for your efforts! (Allow me to also chime in..) I suppose after this is merged, numba will have a follow-up PR to use NewPassManager. I found the new one...

Return `Tuple` type containing `Record` type has an error

I dig into this issue, turned out that I think we just need a conversion from `[8 * i8]` to its pointer type, then everything should be fine. How to...

Return `Tuple` type containing `Record` type has an error

Yeah, I think you nailed it. @gmarkall I tried with this fix ```python def from_data(self, builder, value): # alloca a Record ptr and make it point to value # but...

Return `Tuple` type containing `Record` type has an error

So you mean after a fix, we could meet use-after-free bugs? If we don't return it back to python (I mean we only return record to another jitted function), do...