Denis Laxalde

Results 98 comments of Denis Laxalde

Setting `"ordered": false` to override the default behavior of JSON arrays seems fine to me.

Indeed; there are some discrepancies here. Will look into this. Thank you for the report.

> In the CI, the rpm build is actually currently creating a package for version 0.15.3 because it's hard written. The same is true for debian/changelog which currently needs manual...

Looks reasonable. By the way, it's not clear to me why `datetime.strptime()` is not used directly here.

We could try different parsing methods (`strptime`, or even `datetime.fromisoformat()` when there is no tz info). Another option would be to use https://dateutil.readthedocs.io/en/stable/ but that would pull a dependency (the...

Handling more message types would indeed make sense; but this should not be implemented by hard-coding another value, rather by adding a mechanism to extend the prefix-to-message_type map from user...

The fix from #1253 does not cover this inheritance case, indeed. I'll see if this can be fixed.

#1289 fixes a slightly different version of the original problem, namely when the child class is also a (slotted) attr class, thus from the original example: ```python @define class Sup(Bob):...

https://github.com/python-attrs/attrs/pull/1291 is another attempt, which resolves both situations mentioned above.

I missed the impact of using `__getattribute__()` over `__getattr__()` on performance and I agree it's important to consider and perhaps makes the change I suggested unacceptable. Having hacked significantly on...