tools icon indicating copy to clipboard operation
tools copied to clipboard

Dustmite/polyhash.d: Surround gcc assembly operands in parentheses

Open the-horo opened this issue 2 months ago • 4 comments

Compiling with recent versions of gdc results in errors:

DustMite/polyhash.d-mixin-289:293:13: error: ‘low’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-289:293:23: error: ‘high’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-289:294:12: error: ‘a’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-289:294:20: error: ‘b’ must be surrounded by parentheses
DustMite/polyhash.d:165:37: error: template instance ‘polyhash.longMul!ulong’ error instantiating
  165 |                 this.value = longMul(this.value, operand.value).longDiv(q).remainder;
      |                                     ^
DustMite/polyhash.d:32:35: note: instantiated from here: ‘opOpAssign!"*"’
   32 |                                 v *= v;
      |                                   ^
DustMite/splitter.d:50:28: note: instantiated from here: ‘PolynomialHash!(ModQ!(ulong, 18446744073709551557LU))’
   50 |         alias EntityHash = PolynomialHash!(ModQ!(ulong, largest64bitPrime));
      |                            ^
DustMite/polyhash.d-mixin-362:366:13: error: ‘quotient’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-362:366:28: error: ‘remainder’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-362:367:12: error: ‘low’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-362:367:21: error: ‘high’ must be surrounded by parentheses
DustMite/polyhash.d-mixin-362:367:32: error: ‘b’ must be surrounded by parentheses
DustMite/polyhash.d:165:72: error: template instance ‘polyhash.longDiv!(ulong, LongInt!(64u, false))’ error instantiating
  165 |                this.value = longMul(this.value, operand.value).longDiv(q).remainder;
      |                                                                       ^

DustMite/polyhash.d:32:35: note: instantiated from here: ‘opOpAssign!"*"’
   32 |                                 v *= v;
      |                                   ^
DustMite/splitter.d:50:28: note: instantiated from here: ‘PolynomialHash!(ModQ!(ulong, 18446744073709551557LU))’
   50 |         alias EntityHash = PolynomialHash!(ModQ!(ulong, largest64bitPrime));
      |                            ^

the-horo avatar Apr 25 '24 14:04 the-horo