tools icon indicating copy to clipboard operation
tools copied to clipboard

test_extractor: Allow compile-only unittests for certain version's

Open MoonlightSentinel opened this issue 4 years ago • 2 comments

This enables e.g. verification for tests hidden by version (StdDoc) without running them (wich usually are version'ed for exactly that reason).

This change wraps the unittest body in if (false) { ... } if it's located within a version passed via --compileOnlyVersions.

CC @CyberShadow Opted for a different flag because both behaviours have their merit.

MoonlightSentinel avatar Apr 25 '21 20:04 MoonlightSentinel

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + tools#438"

dlang-bot avatar Apr 25 '21 20:04 dlang-bot

Honestly I feel like we are over-engineering this. It would have been simpler to just come up with a different test :)

CyberShadow avatar Apr 26 '21 01:04 CyberShadow